Great job Jud6ment. I think I'll bug shadowone for the earthbound release to clear the open projects in the dev area

It is possible that I write a code for Kirby Superstar (if here is a desire)... but only if music is available.

Conn wrote:Great job Jud6ment. I think I'll bug shadowone for the earthbound release to clear the open projects in the dev area

It is possible that I write a code for Kirby Superstar (if here is a desire)... but only if music is available.

I will finish my current semester in two weeks, and i can get a lot done when i am in-between school semesters. I got 4 PCM sets done during the christmas break so i can finish Kirby Superstar very quickly if you write the code for it when i am not in school and it wont become a open project forever.

As for will there be enough music for it, definitely yes. Kirby reuses a lot of its music in every title including the most recent ones, smash bros has a huge selection of kirby music, Nintendo published a 25th year anniversary instrumental soundtrack, there is a lot of other live professional performances and orchestra recordings, a lot of youtube covers and medleys, i already did a hour search for what songs i think would be hardest to find and got positive results on finding a cover for it.

Awesome, Lufia MSU!
Is the Patch working with the German Version? If not, can you make a Patch for German Language? That Would be cool.
Thanks.

@JUD6MENT

I got 4 PCM sets done during the christmas break so i can finish Kirby Superstar very quickly if you write the code for it when i am not in school and it wont become a open project forever.

https://www.zeldix.net/t1882-kirby-superstar#30448
Much luck to both of us
I hope there won't be much bugs. Make bsnes breakpoint 2004, write hook to map the themes





Last edited by Conn on Fri 5 Apr 2019 - 15:05; edited 1 time in total

@PittStone:
Lufia1 was never officially released in Germany. Please try yourself first, if it doesn't work send me the fan-made translation patch to con.s@gmx.de and I'll see what I can do

@Jud6Ment
Oh and if it is not too much work to copy/paste Lufia2 themes for a second complete set... I'd be grateful

Conn wrote:
@Jud6Ment
Oh and if it is not too much work to copy/paste Lufia2 themes for a second complete set... I'd be grateful

So when i finished, i did try that and turns out the volume levels of the 2 pcm sets are very different, the other one is much louder. I plan to increase the volume on my PCM tracks to make them match, but at the moment, i just wanted to get the project out. Also, i still need to gather the Lufia 2 music to use, some are obvious because Lufia 2 castle kingdom theme can be used for Lufia 1 Castle kingdom theme is a good example. However, some specific levels and locations to Lufia 1 that dont match Lufia 2, or the end scene credits i dont have a PCM track for yet, i will have to improvise what Lufia 2 track fits it best. It wont be too much more work, but it will take some time and i will get there at finishing the alternative choice for the PCM set eventually. I wont leave it hanging forever though, but since i got one part of the project finished I thought why not release it now.

It depends on the sfx level to adjust the music, those need to match and each game is different. I'd rather adjust the tracks you want to use from lufia2 rather than way round.

I didn't expect it being trouble so I'm happy with your set with 75% don't mind the second set we can renounce on this I'd say then

PittStone wrote:Awesome, Lufia MSU!
Is the Patch working with the German Version?  If not, can you make a Patch for German Language? That Would be cool.
Thanks.

It seems to work with the Spanish translation.

Conn wrote:It depends on the sfx level to adjust the music, those need to match and each game is different. I'd rather adjust the tracks you want to use from lufia2 rather than way round.

I didn't expect it being trouble so I'm happy with your set with 75% don't mind the second set we can renounce on this I'd say then

Yeah, i figured that is what i would have to do, who did the lufia 2 PCM? If they shared to me the loop points of the music it would help the work

@Jud6Ment:That was Relikk, he's really an expert in music and pcm making, so I guess he's a big help here.

@PittStone: I traced the differences and see no conflicts using this translation: http://www.romhacking.net/forum/index.php?topic=6282.0
All should work fine

@Conn:  O.k. i forgot that is not officially released. I tested the "Digisalt" 1.0 German Patch and Patched it with the msu Patch. Its Working.  
The Only thing was, the "Digisalt" Patch "UnHeadered" makes a Header after patching on the Non Headered "Lufia (USA)" and than the msu patch only working after Remove the Header again.

[quote="Conn"]@PittStone:
Lufia1 was never officially released in Germany. Please try yourself first.

yes, that header thing. You can also first patch the msu on the non-header, and then the german patch. My patch expands the rom to 2mb and the translation uses space in the 1mb region. So no conflicts if you patch right

Conn wrote:yes, that header thing. You can also first patch the msu on the non-header, and then the german patch. My patch expands the rom to 2mb and the translation uses space in the 1mb region. So no conflicts if you patch right

Unfortunately your hack is not compatible with Lufia Restored patch (the same case of Lufia II MSU-1 and Frue Lufia).

The problem with compatibility is this:
the restored patch expands the 1Mb original rom to 1.5 MB
the msu hack does the same.

When applying the patch to a native rom, all unused bytes gets zeroed, so simply re-allocating my code (which would be really easy) does not help.

What needs to be done is :
- patch the original headered rom with the restored patch (you get a 1.5MB large rom
-remove the header
- open luf1_msu.asm (the source code)- addresses in the expanded area are unfortunately shared by the msu hack and the resored hack. So you need to change:

Code:

org $208000 -> org $2E8000
LDA $208200,x -> LDA $2E8200,x
org $208200 ; loop table -> org $2E8200

So all you see with $208xxx needs to get 2E8xxx

Then apply the modified asm with xkas on your rom and it should work.

I am uncertain whether I should provide a merged patch since this would mean "stealing" their credits (I did that for super ghoul's and ghosts and DKC though), but if you have contacts to the author, they are free to implement my msu code into their hack (they should know how to use the source asm).

Ah well, I did it for you. Re-download the patch from first post (clear browser history maybe) and you find a new folder with the restore patch.

This one is merged msu with that from romhacking:
https://www.romhacking.net/hacks/2744/

Apply on NON-Header rom (the original restore is for headered, but this merged is for non-header.

Conn wrote:Ah well, I did it for you. Re-download the patch from first post (clear browser history maybe) and you find a new folder with the restore patch.

It's because of things like this that I love this forum, thank you very much ...

You're welcome... I now added also your Frue Lufia2 to the Lufia2 patch package (find it in that thread).

I hope that's it... all these extra wishes

CONGRATS!!!!!! :-D

Hi, I just register to say that using the Conn Post (30498 / Sun 7 Apr 2019 - 23:47), I manage to apply the MSU asm above the 2.44 restored patch.

1. I use a non headered rom to patch to 2.44 restored (as needed)
2. I edit the ASM file and use xkas to repatch it
3. I use tush to add an header and it's good.

Thanks for all your great work now I have a great game with great music and crappy game sound

That's great, but it should also work by simply applying the ips upon the non-header prepatched 2.44 restored. I can't even recall why I added 2.41 into the archieve - it's not a merged or special compatible version.

Conn wrote:That's great, but it should also work by simply applying the ips upon the non-header prepatched 2.44 restored. I can't even recall why I added 2.41 into the archieve - it's not a merged or special compatible version.

I originally tried:
1. Original unheadered Lufia ROM --> patched to 2.4.4 (still unheadered, but increased size to 1.5MB
2. 2.4.4 patched ROM --> MSU IPS patch = in-game control fail past the initial game save choice menu screen (using SD2SNES Pro). Character cannot move nor access the in-game menu screen.

Next I tried:
1. Edited included ASM file with Notepad+ as Conn described in a previous post
2. 2.4.4 ROM (unheadered) --> patched with edited ASM file via xkas

This 2nd patching attempt seemed to have worked without messing with headers at all. Controls in game are now working, tried a few battles and no glitching.

Use Lufia I The Fortress of Doom (USA).sfc with CRC32: 5E1AA1A6 without header, remember that patches with restoration are already merged with MSU1!

VVV18 wrote:Use Lufia I The Fortress of Doom (USA).sfc with CRC32: 5E1AA1A6 without header, remember that patches with restoration are already merged with MSU1!

Well that certainly makes it easier if that's the case.  It wasn't listed on vivify93's Lufia Restored romhacking page under the "Features" section nor when I did a quick search of the readme for "MSU," so I assumed it wasn't included.

Last edited by TiktaaLink on Mon 31 Jan 2022 - 13:05; edited 1 time in total

I test today with the release of the 2.45 and the MSU isn't included.
Patch 2.45 + modifed MSU ASM is OK.

And there is nowhere mention of MSU in the readme file.


Last edited by nico7550 on Mon 31 Jan 2022 - 13:12; edited 1 time in total